Skip to content

Clean up provider specfic code, remove provider related logic #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Clean up provider specfic code, remove provider related logic #195

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions populator-machinery/controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,6 @@ type PopulatorParams struct {
Pvc *corev1.PersistentVolumeClaim
// PvcPrime is the temporary PVC created by volume populator
PvcPrime *corev1.PersistentVolumeClaim
// PV refers to the storage instance where data will be transferred, and it will be bound to the original PVC when the data transfer is complete
PV *corev1.PersistentVolume
// StorageClass is the original StorageClass Pvc refer to
StorageClass *storagev1.StorageClass
// Unstructured is the CR data source created by user
Expand Down Expand Up @@ -776,11 +774,6 @@ func (c *controller) syncPvc(ctx context.Context, key, pvcNamespace, pvcName str
// We'll get called again later when the pvcPrime gets bounded
return nil
}
pv, err := params.KubeClient.CoreV1().PersistentVolumes().Get(ctx, pvcPrime.Spec.VolumeName, metav1.GetOptions{})
if err != nil {
return err
}
params.PV = pv

err = c.providerFunctionConfig.PopulateFn(ctx, *params)
if err != nil {
Expand Down