This repository was archived by the owner on Jul 30, 2021. It is now read-only.
Streamline make generate #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
size/S
chuckha
reviewed
Aug 13, 2019
Makefile
Outdated
| $(CONTROLLER_GEN) object:headerFile=./hack/boilerplate.go.txt paths=./api/... | ||
|
|
||
| # Generate manifests e.g. CRD, RBAC etc. | ||
| .PHONY: generate-manifests | ||
| generate-manifests: |
There was a problem hiding this comment.
This and generate-deepcopy need to depend on $(CONTROLLER_GEN) just like generate does. They should be able to run independently of generate.
| @@ -64,20 +64,15 @@ run: generate fmt vet | |||
|
|
|||
| # Install CRDs into a cluster | |||
| .PHONY: install | |||
| install: manifests | |||
| install: generate | |||
There was a problem hiding this comment.
this only depends on generate-manifests
| $(MAKE) generate-deepcopy | ||
|
|
||
| # Generate deepcopy files. | ||
| .PHONY: generate-deepcopy |
There was a problem hiding this comment.
this is missing the actual target name
needs a generate-deepcopy: on the next line
k8s-ci-robot
added
the
needs-rebase
vincepri
force-pushed
the
cleanup-makefile-generate
branch
from
8025542 to
ab39b63
Compare
k8s-ci-robot
removed
the
needs-rebase
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
cleanup-makefile-generate
branch
from
ab39b63 to
5bef887
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR aligns this Makefile with the other Cluster API repositories, where
make generateruns a bunch of*-generatetargets.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: