Skip to content

Add gocyclo to the golangci linters #1088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
devigned opened this issue Dec 19, 2020 · 2 comments · Fixed by #1106
Closed

Add gocyclo to the golangci linters #1088

devigned opened this issue Dec 19, 2020 · 2 comments · Fixed by #1106
Assignees
@Evalle
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@devigned
Copy link
Contributor

/kind feature

Describe the solution you'd like
Add gocyclo to the .golangci.yml and fix up any of the issues caused by the new linter rules.

Wait until #1067 is merged since Reconcile currently has a high complexity score (31) which will trigger an error, and #1067 contains a refactor which will reduce the complexity.

/help
/good-first-issue
@k8s-ci-robot
Copy link
Contributor

@devigned:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/kind feature

Describe the solution you'd like
Add gocyclo to the .golangci.yml and fix up any of the issues caused by the new linter rules.

Wait until #1067 is merged since Reconcile currently has a high complexity score (31) which will trigger an error, and #1067 contains a refactor which will reduce the complexity.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Dec 19, 2020
@Evalle
Copy link
Contributor

Evalle commented Jan 6, 2021

/assign

@Evalle Evalle mentioned this issue Jan 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Evalle Evalle

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add gocyclo to the golangci linters Evalle/cluster-api-provider-azure
3 participants
@devigned @Evalle @k8s-ci-robot