Add gocyclo to the golangci linters

[Evalle]

What type of PR is this?
/kind feature

What this PR does / why we need it:
Adds gocyclo to the golangci linters

Which issue(s) this PR fixes
Fixes #1088

Special notes for your reviewer:
On hold until #1067 is merged

Release note:

none

[k8s-ci-robot]

Hi @Evalle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Evalle]

FYI: @devigned

[cpanato]

/ok-to-test

[cpanato]

/lgtm

[cpanato]

Can you add a reason why we need to add this linter? thanks!

[cpanato]

/test pull-cluster-api-provider-azure-e2e

[devigned]

@cpanato in #1088, I had mentioned:

Wait until #1067 is merged since Reconcile currently has a high complexity score (31) which will trigger an error, and #1067 contains a refactor which will reduce the complexity.

We have started to see some of our functions become too complex to easily understand. The cyclomatic complexity linter will help us to indicate functionality that needs to be refactored.

IMO, the upper bound cyclomatic complexity score of 30 (default) is higher than I might set it for a community based project where we strive to be as accessible as possible for folks. I think the higher we set the score, the higher we set the bar for the required expertise needed to maintain the project. The lower we can set the score, the easier it will be for folks to understand what is happening in the code.

[CecileRobertMichon]

/retest
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment