Skip to content

Refactor MachineSet reconciler to be consistent with Cluster and Machine patterns #1689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ncdc opened this issue Oct 30, 2019 · 8 comments · Fixed by #3904
Closed

Refactor MachineSet reconciler to be consistent with Cluster and Machine patterns #1689

ncdc opened this issue Oct 30, 2019 · 8 comments · Fixed by #3904
Assignees
@srm09
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@ncdc
Copy link
Contributor

ncdc commented Oct 30, 2019

We rewrote the Cluster and Machine controllers in v1alpha2 using new patterns and conventions. For example, we use a defer statement with our patch helper to ensure the object being reconciled is always patched to persist whatever changes we made when reconciling.

We should update the MachineSet reconciler to follow these patterns.

/priority important-longterm
/kind cleanup
@k8s-ci-robot k8s-ci-robot added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Oct 30, 2019
@vincepri vincepri self-assigned this Oct 30, 2019
@ncdc ncdc added this to the v0.3.0 milestone Nov 6, 2019
@vincepri vincepri mentioned this issue Nov 12, 2019
Closed
@ncdc ncdc modified the milestones: v0.3.0, Next Dec 6, 2019
@vincepri vincepri mentioned this issue Dec 20, 2019
Merged
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 5, 2020
@vincepri
Copy link
Member

vincepri commented Mar 5, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 5, 2020
@vincepri vincepri mentioned this issue Mar 11, 2020
Closed
@vincepri vincepri removed their assignment Apr 20, 2020
@vincepri
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Oct 16, 2020
@srm09
Copy link
Contributor

srm09 commented Oct 22, 2020

/assign

@srm09
Copy link
Contributor

srm09 commented Oct 26, 2020

/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Oct 26, 2020
@vincepri
Copy link
Member

vincepri commented Nov 2, 2020

@srm09 Are you still working on this issue?

@srm09
Copy link
Contributor

srm09 commented Nov 2, 2020

Yes @vincepri
I would be creating a PR soon enough.

@srm09 srm09 mentioned this issue Nov 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srm09 srm09

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🌱 Move MachineSet patching to a defer call srm09/cluster-api
5 participants
@ncdc @vincepri @srm09 @k8s-ci-robot @fejta-bot