✨ Refactor MS controller status patching

[vincepri]

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:

This PR improves the MachineSet code by:

• Moves all the code to sync Status to machineset_controller.go.
• Uses patch instead of update for the status resource, but fall back to Update if the validation fails (explained in comment).
• Moves setting Status.Selector in calculateStatus instead of the main reconciler function.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1689

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vincepri]

/hold

[vincepri]

/hold cancel
/assign @ncdc

[ncdc]

The bulk of this was just copy/paste across files, right?

[vincepri]

/assign @detiber

[detiber]

Question related to ignoring the error when converting the labelselector, otherwise, lgtm

[detiber]

Is it actually safe to ignore the error here? I know we have a validating webhook now, but that wouldn't affect pre-existing stored resources (unless they have been read and then re-written to the new storage version).

[vincepri]

I figured given that we're coming from a LabelSelector type that this function should never return an error, unless something very wrong happened.

I'll add it though, just to be safe

[detiber]

/lgtm