-
Notifications
You must be signed in to change notification settings - Fork 1.4k
📖 Add automatic redirects for the development docs book to Netlify config #1843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: detiber The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
My only remaining question is just confirming that we don't have anything that cares about |
It's configured in the |
Ok, so it won't be an issue that we're removing it from master, right? |
Correct. |
/lgtm |
/hold cancel |
@vincepri The DNS config has not been merged yet... |
I think the DNS change is in now? |
It is, however I had forgotten that Netlify does not like the use of CNAME records where the dns subdomain used does not match the Netlify URL prefix for the branch. I've created kubernetes/k8s.io#488 to update the DNS records properly and #1848 to re-add the proper redirects. |
What this PR does / why we need it:
Adds automated redirects for the master/development version of the Cluster API book
/hold
Depends on: kubernetes/k8s.io#486
/assign @ncdc
/kind documentation