Skip to content

📖 Add automatic redirects for the development docs book to Netlify config #1843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Dec 5, 2019

What this PR does / why we need it:

Adds automated redirects for the master/development version of the Cluster API book

/hold
Depends on: kubernetes/k8s.io#486

/assign @ncdc
/kind documentation

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 5, 2019
@k8s-ci-robot k8s-ci-robot requested review from justinsb and ncdc December 5, 2019 18:53
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2019
@ncdc
Copy link
Contributor

ncdc commented Dec 5, 2019

My only remaining question is just confirming that we don't have anything that cares about kubernetes-sigs-cluster-api.netlify.com, since it's being dropped from this config?

@detiber
Copy link
Member Author

detiber commented Dec 5, 2019

My only remaining question is just confirming that we don't have anything that cares about kubernetes-sigs-cluster-api.netlify.com, since it's being dropped from this config?

It's configured in the netlify.toml for the release-0.2 branch, which owns that URL (as it is configured as the default branch in Netlify).

@ncdc
Copy link
Contributor

ncdc commented Dec 5, 2019

Ok, so it won't be an issue that we're removing it from master, right?

@detiber
Copy link
Member Author

detiber commented Dec 5, 2019

Ok, so it won't be an issue that we're removing it from master, right?

Correct.

@ncdc
Copy link
Contributor

ncdc commented Dec 5, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 5, 2019
@vincepri
Copy link
Member

vincepri commented Dec 5, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2019
@k8s-ci-robot k8s-ci-robot merged commit ed11872 into kubernetes-sigs:master Dec 5, 2019
@detiber
Copy link
Member Author

detiber commented Dec 6, 2019

@vincepri The DNS config has not been merged yet...

@ncdc
Copy link
Contributor

ncdc commented Dec 6, 2019

I think the DNS change is in now?

@detiber
Copy link
Member Author

detiber commented Dec 6, 2019

It is, however I had forgotten that Netlify does not like the use of CNAME records where the dns subdomain used does not match the Netlify URL prefix for the branch. I've created kubernetes/k8s.io#488 to update the DNS records properly and #1848 to re-add the proper redirects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants