Skip to content

Update DNS for development branch for the cluster-api documentation #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 6, 2019
Merged

Update DNS for development branch for the cluster-api documentation #488

merged 1 commit into from
Dec 6, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Dec 6, 2019

I had previously forgotten that the subdomain used needs to be the same as the branch prefix for the Netlify URL, updated the DNS records accordingly.

/assign @ncdc @cblecker @dims

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin December 6, 2019 14:34
@k8s-ci-robot k8s-ci-robot added area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ wg/k8s-infra labels Dec 6, 2019
@detiber detiber mentioned this pull request Dec 6, 2019
Merged
@dims
Copy link
Member

dims commented Dec 6, 2019

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2019
@haosdent
Copy link
Member

haosdent commented Dec 6, 2019

lgtm

vincepri
vincepri approved these changes Dec 6, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0c3f3b8 into kubernetes:master Dec 6, 2019
@detiber
Copy link
Member Author

detiber commented Dec 6, 2019

Manual action is still required on this as the DNS update isn't automated on postsubmit (yet).

@detiber detiber mentioned this pull request Dec 6, 2019
Merged
@detiber
Copy link
Member Author

detiber commented Dec 6, 2019

This has been completed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@dims dims Awaiting requested review from dims

@thockin thockin Awaiting requested review from thockin

Assignees

@ncdc ncdc

@dims dims

@cblecker cblecker

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@detiber @dims @k8s-ci-robot @haosdent @vincepri @ncdc @cblecker