✨clusterctl: add support for local override of files read from provider's repository #1981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
62 tasks
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
vincepri
reviewed
Jan 2, 2020
vincepri
reviewed
Jan 2, 2020
|
@vincepri comment addressed, let me know if I can squash commits |
|
go for it! this looks ready to go |
fabriziopandini
force-pushed
the
clusterctl-local-overrides
branch
from
efa4028 to
2febc3a
Compare
|
@vincepri squash done |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR introduces in clusterctl the possibility to define local overrides for the files read from the provider's Repository.
This is required for development purposes, but it can be used also in production as a workaround for problems on the official repositories.
Local override files are searched under
$home/cluster-api/overrides/provider-name/version/pathNB. local override files provide a way to replace only specific files while everything else still remains hosted in the provider repository/on GitHub; the local file system repository implementation provides a complete replacement of provider repository/a github repository
Which issue(s) this PR fixes
Rif #1729
/assign @vincepri