✨clusterctl: improve move test framework #2059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
This was referenced Jan 14, 2020
vincepri
reviewed
Jan 15, 2020
ncdc
reviewed
Jan 15, 2020
cmd/clusterctl/pkg/internal/test/providers/bootstrap/dummy_types.go
Outdated
Show resolved
Hide resolved
cmd/clusterctl/pkg/internal/test/providers/infrastructure/dummy_types.go
Show resolved
Hide resolved
cmd/clusterctl/pkg/internal/test/providers/infrastructure/dummy_types.go
Show resolved
Hide resolved
cmd/clusterctl/pkg/internal/test/providers/infrastructure/dummy_types.go
Show resolved
Hide resolved
cmd/clusterctl/pkg/internal/test/providers/controlplane/groupversion_info.go
Show resolved
Hide resolved
cmd/clusterctl/pkg/internal/test/providers/bootstrap/groupversion_info.go
Show resolved
Hide resolved
|
LGTM! Will need squashing once @vincepri is done reviewing. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini, ncdc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
LGTM pending squash |
fabriziopandini
force-pushed
the
clusterctl-improve-move-test-framework
branch
from
919c9d1 to
9d17c42
Compare
|
@vincepri squashed |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR improves the move test framework addressing the requirements of the new "move by owner ref" approach and more specifically:
Which issue(s) this PR fixes
Rif #1729
/assign @vincepri