Fix an issue where clusterClient's temporary kubeconfig files could persist after the application terminates. Add comments for the clusterclient New(...) methods. #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
spew
force-pushed
the
fix-cluster-client-new-issues
branch
2 times, most recently
from
1c84ee3 to
538e226
Compare
|
/assign @roberthbailey @k4leung4 @mkjelland |
spew
force-pushed
the
fix-cluster-client-new-issues
branch
from
538e226 to
bc481a2
Compare
|
lgtm (please fix the nit though) |
|
Hi @roberthbailey I don't see any comment on what to change. |
|
|
||
| func ifErrRemove(pErr *error, path string) { | ||
| if *pErr != nil { | ||
| err := os.Remove(path) |
There was a problem hiding this comment.
nit: should be cuddled:
if err := os.Remove(); err != nil { ... }
…ersist after the application terminates. Add comments for the clusterclient New(...) methods.
spew
force-pushed
the
fix-cluster-client-new-issues
branch
from
bc481a2 to
856ca7e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As pointed out by @roberthbailey on PR #384 there are opportunities for clusterclient to persist temporary files even after the application terminates. Namely in error scenarios while creating the clusterclient. This PR addresses those issues.
Special notes for your reviewer:
Release note:
@kubernetes/kube-deploy-reviewers