Move from (f *File).WriteString(...) to ioutil.WriteFile(...) to Fix a bug where WriteString fails because the file is closed before writing. #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a bug where WriteString fails because the file is closed before writing. In a previous commit we started closing the file in createTempFile after having it returned to ensure that the os.Remove(...) would not result in error due to an open file handle. This caused WriteString to start failing.
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/assign @k4leung4 @roberthbailey |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
jayunit100
pushed a commit
to jayunit100/cluster-api
that referenced
this pull request
Jan 31, 2020
Update object patch logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous commit in PR #390 we started closing the file in createTempFile after having it returned to ensure that the os.Remove(...) would not result in error due to an open file handle. This caused WriteString to start failing.
What this PR does / why we need it:
Without this PR
clusterctl create clusterconsistently fails. For some reason in my testing of PR #390 I did not see this issue. I think I likely didn't build clusterctl correctly (another reason why we need unit tests for this file!)Release note:
@kubernetes/kube-deploy-reviewers