Skip to content

✨ RuntimeSDK: Add caBundle injection to Extension controller #6632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2022
Merged

✨ RuntimeSDK: Add caBundle injection to Extension controller #6632

merged 1 commit into from
Jun 13, 2022

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

  • injects the ca.crt data from a secret referred by the annotation runtime.cluster.x-k8s.io/inject-ca-from-secret into spec.clientConfig.caBundle
  • adds a watch for secrets but only their metadata, not secret data to the extension controller to ensure updates to the secret referred by an ExtensionConfig annotation triggers updates of the caBundle too.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #6507

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 13, 2022
sbueringer
sbueringer reviewed Jun 13, 2022
View reviewed changes
@chrischdi chrischdi force-pushed the pr-topology-mutation-external branch 4 times, most recently from e1659db to b63b8ba Compare June 13, 2022 12:25
@chrischdi
Copy link
Member Author

/test pull-cluster-api-test-main

@chrischdi chrischdi changed the title ✨ [WIP] RuntimeSDK: Add caBundle injection to Extension controller ✨ RuntimeSDK: Add caBundle injection to Extension controller Jun 13, 2022
@sbueringer
Copy link
Member

Nice!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@sbueringer sbueringer added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jun 13, 2022
killianmuldoon
killianmuldoon approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

fabriziopandini
fabriziopandini reviewed Jun 13, 2022
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits, nothing really blocking

@fabriziopandini fabriziopandini mentioned this pull request Jun 13, 2022
Merged
@chrischdi chrischdi force-pushed the pr-topology-mutation-external branch from b63b8ba to b319067 Compare June 13, 2022 17:11
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main b319067 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sbueringer
Copy link
Member

/retest

@chrischdi chrischdi force-pushed the pr-topology-mutation-external branch from b319067 to 2706248 Compare June 13, 2022 17:32
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit 9bb071e into kubernetes-sigs:main Jun 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Jun 13, 2022
This was referenced Jun 14, 2022
Merged
Merged
@chrischdi chrischdi deleted the pr-topology-mutation-external branch June 30, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

RuntimeSDK: seamless certificate handling for RuntimeExtensions
5 participants
@chrischdi @sbueringer @fabriziopandini @k8s-ci-robot @killianmuldoon