🐛 Remove message from Runtime SDK FailureResponses

[killianmuldoon]

Signed-off-by: killianmuldoon [email protected]

Remove the Message returned from the Runtime extension from the error returned by CallExtension and Discovery. This message may be unique and could cause too many reconciliation loops as in #5945

Fixes #6921

[killianmuldoon]

/hold

Just investigating if this has any impact on the e2e tests where we compare the blocking condition.

[killianmuldoon]

/unhold
/area runtime-sdk
The test is running fine on my machine and in the CI.

[enxebre]

We might to eventually categorised the errors to provide a more meaningful message without triggering extra loops.
Also I wonder if it should be the consumer setting the condition doing the discrimination and setting the error message it.

/lgtm

[killianmuldoon]

We might to eventually categorised the errors to provide a more meaningful message without triggering extra loops.
Also I wonder if it should be the consumer setting the condition doing the discrimination and setting the error message it.

This is hard because these errors are currently returned by the user. The issue with Message as it is is that they're fully defined by the Runtime Extension. Even if we had fixed errors that could us e.g. errors.Cause() we couldn't be certain they'd be used without some additional validation (which would mean failing due to non-conforming error messages which seems like bad UX 😆)

If you have any ideas on this though it would be great to hear them.

[sbueringer]

/lgtm

[fabriziopandini]

/lgtm
/approve

/cherry-pick release-1.2

If in future we will reconsider this because user find it complex to investigate problems, we should make sure to document that error message should be idempotent

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@fabriziopandini: new pull request created: #6955

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.