-
Notifications
You must be signed in to change notification settings - Fork 60
Use NamespacedName Type for Internal APIs #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
and avoids switching the two parameters, which will likely be placed after each other in func parameters |
The inferncepool and inferencemodel reconcilers are using separate string fields instead of NamespacedName even with #165. /reopen |
@danehans: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Internal APIs, e.g. EndpointSliceReconciler, use separate ns and name strings to represent the ns/name of CRs. A few benefits of using NamespacedName are:
String()
that automatically format the resource identifier in the conventional namespace/name format, reducing boilerplate code and potential formatting errors.The text was updated successfully, but these errors were encountered: