ext-proc: remove unused fields from EndpointSliceReconciler #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
kfswain
reviewed
Jan 7, 2025
| PoolName string | ||
| ServiceName string | ||
| Zone string | ||
| Namespace string |
There was a problem hiding this comment.
I just checked...we actually don't use these fields anymore, since we now check if the ServiceName owns the EndpointSlice. I think we can remove the field altogether, thanks for catching this!
There was a problem hiding this comment.
@kfswain good point!
I've removed the field.
Signed-off-by: Madhav Jivrajani <[email protected]>
MadhavJivrajani
force-pushed
the
use-namespaced-name
branch
from
e93b832 to
23acb74
Compare
k8s-ci-robot
added
size/XS
MadhavJivrajani
changed the title
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, MadhavJivrajani The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
courageJ
pushed a commit
to courageJ/llm-instance-gateway
that referenced
this pull request
Jan 8, 2025
…es-sigs#165) Signed-off-by: Madhav Jivrajani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157
(the above issue is obsolete now that we are removing the field itself)