Skip to content

Fine grained handling of metrics scraping failures #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #493
ahg-g opened this issue Mar 14, 2025 · 3 comments
Closed
Tracked by #493

Fine grained handling of metrics scraping failures #495

ahg-g opened this issue Mar 14, 2025 · 3 comments

Comments

@ahg-g
Copy link
Contributor

ahg-g commented Mar 14, 2025

What would you like to be added:

Currently model server metrics are not updated if we fail to find any of the metrics (e.g., if lora info doesn't exist, we don't update the kv-cache and queue length metrics). We should not have an all-or-nothing behavior and update whatever metrics we find, but we should still log that not all metrics where updated.

Why is this needed:

Not all servers support lora info now.

@ahg-g ahg-g mentioned this issue Mar 14, 2025
14 tasks
@ahg-g
Copy link
Contributor Author

ahg-g commented Mar 14, 2025

/assign @BenjaminBraunDev

@k8s-ci-robot
Copy link
Contributor

@ahg-g: GitHub didn't allow me to assign the following users: BenjaminBraunDev.

Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @BenjaminBraunDev

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahg-g ahg-g closed this as completed Mar 14, 2025
@BenjaminBraunDev
Copy link
Contributor

This should allow us to do this cleanly: #503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants