Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nil option for metric_spec to specify metrics to not be scraped. #503

Merged
merged 4 commits into from
Mar 17, 2025
Merged

Add nil option for metric_spec to specify metrics to not be scraped. #503

merged 4 commits into from
Mar 17, 2025

Conversation

BenjaminBraunDev
Copy link
Contributor

Addendum to #461 to allow metric_spec to be nil for specific metric scraping.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 14, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 14, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @BenjaminBraunDev. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 14, 2025
@netlify Netlify
Copy link

netlify bot commented Mar 14, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit cb396db
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67d87497a27e440008bbc8b3
😎 Deploy Preview https://deploy-preview-503--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@BenjaminBraunDev BenjaminBraunDev mentioned this pull request Mar 14, 2025
Closed
ahg-g
ahg-g reviewed Mar 14, 2025
View reviewed changes
Copy link
Contributor

@ahg-g ahg-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log an error somewhere that the metric is not being scraped.

@BenjaminBraunDev
Copy link
Contributor Author

Can we log an error somewhere that the metric is not being scraped.

Yeah, I'll put it in the metric_spec NewMetricMapping so as to not spam the logs.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 15, 2025
ahg-g
ahg-g reviewed Mar 15, 2025
View reviewed changes
cmd/epp/main.go Outdated
@@ -155,6 +155,7 @@ func run() error {

// Set up mapper for metric scraping.
mapping, err := backendmetrics.NewMetricMapping(
ctx,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to pass the ctx, just check here and log which metrics are set to an empty string and will not be scraped.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@ahg-g
Copy link
Contributor

ahg-g commented Mar 15, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 15, 2025
@BenjaminBraunDev
Copy link
Contributor Author

Updated the Dockerfile for go 1.24, this was required for me to build the EPP image. This lines up the go version update in #501

@ahg-g
Copy link
Contributor

ahg-g commented Mar 17, 2025

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, BenjaminBraunDev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7f839ae into kubernetes-sigs:main Mar 17, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@danehans danehans Awaiting requested review from danehans

@Jeffwan Jeffwan Awaiting requested review from Jeffwan

Assignees

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenjaminBraunDev @k8s-ci-robot @ahg-g