Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Metrics] Add input/output token and request size metrics #214

Merged
merged 5 commits into from
Jan 25, 2025
Merged

[Metrics] Add input/output token and request size metrics #214

merged 5 commits into from
Jan 25, 2025

Conversation

JeffLuoo
Copy link
Contributor

  • input and output token metrics

  • request size in bytes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @JeffLuoo!

It looks like this is your first PR to kubernetes-sigs/gateway-api-inference-extension 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gateway-api-inference-extension has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 21, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @JeffLuoo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 21, 2025
@JeffLuoo
Copy link
Contributor Author

@courageJ @liu-cong @ahg-g

@netlify Netlify
Copy link

netlify bot commented Jan 21, 2025 •
edited
Loading

✅ Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 01ca1aa
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67954ad403b96a0008234a9d
😎 Deploy Preview https://deploy-preview-214--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 90f0c1e to 27a923d Compare January 21, 2025 18:02
@JeffLuoo JeffLuoo changed the title [Metrics] Add more metrics [Metrics] Add input/output token and request size metrics Jan 21, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Jan 21, 2025

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 21, 2025
@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 27a923d to 627c012 Compare January 21, 2025 20:03
@JeffLuoo JeffLuoo requested a review from liu-cong January 21, 2025 20:03
@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 21, 2025
courageJ
courageJ suggested changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@courageJ courageJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add metrics doc for these metrics. Thanks.

@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 627c012 to b944af9 Compare January 22, 2025 14:53
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2025
@JeffLuoo JeffLuoo requested a review from courageJ January 22, 2025 14:54
@courageJ
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@courageJ: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from b944af9 to 8183b1c Compare January 22, 2025 20:03
@JeffLuoo JeffLuoo requested a review from liu-cong January 22, 2025 20:03
@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@JeffLuoo JeffLuoo requested a review from ahg-g January 23, 2025 14:33
@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 8183b1c to 323ecf2 Compare January 23, 2025 21:47
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 23, 2025
@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 323ecf2 to 55c5ea3 Compare January 23, 2025 21:48
liu-cong
liu-cong reviewed Jan 23, 2025
View reviewed changes
Copy link
Contributor

@liu-cong liu-cong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just rephrased a bit to simplify for the user. We simply say response metrics for streaming isn't supported at this moment (streaming without response metrics still works), instead of explaining the nuances of unexpected behaviors.

@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from 55c5ea3 to df5926f Compare January 24, 2025 14:30
@JeffLuoo JeffLuoo requested a review from liu-cong January 24, 2025 14:30
@JeffLuoo
[Metrics] Add input/output token and request size metrics
5d8f329 
Data will only populate if use buffered mode.
@JeffLuoo JeffLuoo force-pushed the token-response-metrics branch from df5926f to 5d8f329 Compare January 24, 2025 14:32
@liu-cong
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 24, 2025
ahg-g
ahg-g reviewed Jan 24, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
ahg-g
ahg-g reviewed Jan 25, 2025
View reviewed changes
@ahg-g
Copy link
Contributor

ahg-g commented Jan 25, 2025

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, JeffLuoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2025
@k8s-ci-robot k8s-ci-robot merged commit bfe0e54 into kubernetes-sigs:main Jan 25, 2025
8 checks passed
kfswain pushed a commit to kfswain/llm-instance-gateway that referenced this pull request Jan 27, 2025
@JeffLuoo @ahg-g @kfswain
[Metrics] Add input/output token and request size metrics (kubernetes…
27457e1 
…-sigs#214)

* [Metrics] Add input/output token and request size metrics

Data will only populate if use buffered mode.

* Update pkg/ext-proc/metrics/README.md

* Update pkg/ext-proc/metrics/README.md

* Update pkg/ext-proc/metrics/README.md

* Update pkg/ext-proc/metrics/README.md

---------

Co-authored-by: Abdullah Gharaibeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahg-g ahg-g ahg-g left review comments

@courageJ courageJ Awaiting requested review from courageJ

@liu-cong liu-cong Awaiting requested review from liu-cong

Assignees

@liu-cong liu-cong

@ahg-g ahg-g

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JeffLuoo @k8s-ci-robot @ahg-g @liu-cong @courageJ