Release setup #274
Release setup #274
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
size/L
ahg-g
force-pushed
the
artifacts
branch
4 times, most recently
from
233c73b to
3ce9e38
Compare
| - [ ] Update things like README, deployment templates, docs, configuration, test/e2e flags. | ||
| Submit a PR against the release branch. | ||
| - [ ] A maintainer [prepares a draft release](https://github.com/kubernetes-sigs/gateway-api-inference-extension/releases) | ||
| - [ ] Write the change log into the draft release. |
There was a problem hiding this comment.
Will this project follow the GW API approach to changelog management (xref)?
There was a problem hiding this comment.
Can you please suggest what the exact step that we should add here?
There was a problem hiding this comment.
I'll defer to @robscott since he understands how GW API performs changelog management.
There was a problem hiding this comment.
I'd recommend incorporating something like this: https://github.com/kubernetes-sigs/gateway-api/blob/main/RELEASE.md#writing-a-changelog
| artifacts: kustomize | ||
| if [ -d artifacts ]; then rm -rf artifacts; fi | ||
| mkdir -p artifacts | ||
| $(KUSTOMIZE) build config/crd -o artifacts/manifests.yaml | ||
| @$(call clean-manifests) |
There was a problem hiding this comment.
In addition to cutting the CRDs, we need to consider:
- How do we version the web docs?
- Assets such as the POC example need to be tuned when cutting a release (xref).
There was a problem hiding this comment.
Those will be in the release branch, and so already properly versioned, right?
There was a problem hiding this comment.
@ahg-g not necessarily. For example, the vLLM image tag should be changed from latest to a release tag when cutting a release. The imagePullPolicy should be changed from Always to IfNotPresent. This applies to all images and pull policies in the POC deployments. Neither are blockers for the v0.1 release but something we should consider b/c both are best practices that we should follow.
There was a problem hiding this comment.
Sounds good, lets follow up on that after the first release. I would like to move the manifests directory out of the pkg and also move the guides into the site, I am not sure we will get to in the first release.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
make artifactsrule to generate release artifactsFixes #263