Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Corrects release branch naming #299

Closed
wants to merge 1 commit into from
Closed

Conversation

danehans
Copy link
Contributor

@danehans danehans commented Feb 6, 2025

  • Fixes the release branching naming
  • Adds add'l context for release steps

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from ahg-g and kfswain February 6, 2025 20:30
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 6, 2025
Copy link

netlify bot commented Feb 6, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 7d232c0
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67a51bd1f7eb6c0008a21dfc
😎 Deploy Preview https://deploy-preview-299--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot
Copy link
Contributor

@danehans: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gateway-api-inference-extension-test-unit-main 7d232c0 link true /test pull-gateway-api-inference-extension-test-unit-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kfswain
Copy link
Collaborator

kfswain commented Feb 6, 2025

/lgtm
/hold
This LGTM.
But just an FYI that this was developed on the upstream repo. Can we keep the upstream branches to tagging (and other things that require using the upstream) so there are no 'whoopsie' moments that could bite us?

Just holding to bring attention to the comment, feel free to ack/unhold at your leisure. Thanks again for this!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2025
@ahg-g
Copy link
Contributor

ahg-g commented Feb 11, 2025

Is this PR still relevant?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 11, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@danehans
Copy link
Contributor Author

But just an FYI that this was developed on the upstream repo. Can we keep the upstream branches to tagging (and other things that require using the upstream) so there are no 'whoopsie' moments that could bite us?

Ack. I was trying to recreate it as close to upstream as possible but I agree that this should be done using downstream.

@danehans
Copy link
Contributor Author

danehans commented Feb 13, 2025

Closing in favor of #333

@danehans danehans closed this Feb 13, 2025
@danehans danehans deleted the fix_release_part2 branch February 13, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants