fix: Corrects release branch naming #333
Conversation
Signed-off-by: Daneyon Hansen <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -34,7 +34,7 @@ This document defines the process for releasing Gateway API Inference Extension. | |||
| export RC=1 | |||
| ``` | |||
|
|
|||
| 4. The vLLM image tag defaults to `0.7.2` for a release. Optionally, change the vLLM image tag. For example: | |||
| 4. The vLLM image tag defaults to `v0.7.2` for a release. Set the `VLLM` environment variable if a newer [tag][vllm-tag] has been published. For example: | |||
There was a problem hiding this comment.
nit: Can we instead point to where the tag is defined? That would let us avoid having multiple sources of truth for this info
| 3. Create a new release branch from the `main` branch. The release branch should be named `release-v${MAJOR}.${MINOR}`, e.g. `release-v0.1`. | ||
| 3. Release Branch Handling: | ||
| - For a Release Candidate: | ||
| Create a new release branch from the `main` branch. The branch should be named `release-${MAJOR}.${MINOR}`, for example, `release-0.1`: |
There was a problem hiding this comment.
nit: Leaving a note mentioning that the patch version is intentionally left out may help.
Some examples of other folks making this mistake also:
https://github.com/kubernetes-sigs/lws/branches/stale
|
/lgtm LGTM! I left some ignorable nits, feel free to unhold and submit. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel I guess we can follow up with the suggestions separately |
k8s-ci-robot
removed
the
do-not-merge/hold
VLLMenv var default value for the release doc.