[Metrics] Add metrics validation in integration test #413
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
JeffLuoo
changed the title
|
cc - @courageJ |
JeffLuoo
force-pushed
the
metrics-integration-test
branch
from
47382f1 to
80dcdc8
Compare
| @@ -57,7 +66,8 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| port = runserver.DefaultGrpcPort | |||
| port = runserver.DefaultGrpcPort | |||
| metricsPort = 8888 | |||
There was a problem hiding this comment.
nit: Can we define a DefaultMetricsPort as well?
There was a problem hiding this comment.
The default port 9090 used by metrics is already in use in the integration test so I picked a random port..
There was a problem hiding this comment.
Ideally we should test the same metrics endpoint as in production. Can you add a TODO here to follow up on setting up correct auth in integration test and test the "real" metrics endpoint?
There was a problem hiding this comment.
I add a comment in #326 (comment) to make sure we don't close the issue until it is improved.
Start by adding request total metrics, more validation will be added in follow up. kubernetes-sigs#326
JeffLuoo
force-pushed
the
metrics-integration-test
branch
from
80dcdc8 to
5d78491
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, JeffLuoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Start by adding request total metrics, more validation will be added in follow up.
#326