Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify metrics in integration test #326

Open
Tracked by #362
liu-cong opened this issue Feb 12, 2025 · 2 comments
Open
Tracked by #362

Verify metrics in integration test #326

liu-cong opened this issue Feb 12, 2025 · 2 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@liu-cong
Copy link
Contributor

Hermetic test is a fast way to verify functionality e2e without requiring a real cluster.

We should verify the metrics in each test case.
@liu-cong
Copy link
Contributor Author

cc @JeffLuoo @courageJ

@liu-cong liu-cong mentioned this issue Feb 14, 2025
Merged
@ahg-g ahg-g mentioned this issue Feb 18, 2025
Closed
33 tasks
@kfswain kfswain added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Feb 19, 2025
JeffLuoo added a commit to JeffLuoo/gateway-api-inference-extension that referenced this issue Feb 26, 2025
@JeffLuoo
Add metrics validation in integration test

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
47382f1 
Start by adding request total metrics, more validation will be added in
follow up.

kubernetes-sigs#326
@JeffLuoo JeffLuoo mentioned this issue Feb 26, 2025
Merged
JeffLuoo added a commit to JeffLuoo/gateway-api-inference-extension that referenced this issue Feb 26, 2025
@JeffLuoo
Add metrics validation in integration test
80dcdc8 
Start by adding request total metrics, more validation will be added in
follow up.

kubernetes-sigs#326
JeffLuoo added a commit to JeffLuoo/gateway-api-inference-extension that referenced this issue Feb 27, 2025
@JeffLuoo
Add metrics validation in integration test
5d78491 
Start by adding request total metrics, more validation will be added in
follow up.

kubernetes-sigs#326
@JeffLuoo
Copy link
Contributor

As a followup regarding this comment that we should add authentication in integration test as well.

k8s-ci-robot pushed a commit that referenced this issue Feb 27, 2025
@JeffLuoo
Add metrics validation in integration test (#413)
Loading
Loading status checks…
29bf32d 
Start by adding request total metrics, more validation will be added in
follow up.

#326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@liu-cong @JeffLuoo @kfswain