Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Updates getting started guide for kgateway #575

Closed
wants to merge 1 commit into from

Conversation

danehans
Copy link
Contributor

  • Uses tabs to separate implementations.
  • Moves Envoy Gateway-specific content to Envoy Gateway tab.
  • Adds a Kgateway tab with instructions for using Kgateway as an Inference Gateway.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from kfswain March 25, 2025 19:07
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2025
@k8s-ci-robot k8s-ci-robot requested a review from liu-cong March 25, 2025 19:07
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 25, 2025
Copy link

netlify bot commented Mar 25, 2025

Deploy Preview for gateway-api-inference-extension ready!

Name Link
🔨 Latest commit 18be78e
🔍 Latest deploy log https://app.netlify.com/sites/gateway-api-inference-extension/deploys/67e3a2f299c642000803f9f0
😎 Deploy Preview https://deploy-preview-575--gateway-api-inference-extension.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danehans
Copy link
Contributor Author

I'm using a personal dev build until Kgateway v2.0.0 is cut.

@kfswain
Copy link
Collaborator

kfswain commented Mar 25, 2025

Do we have an eta on Kgateway's v2.0.0?

@danehans
Copy link
Contributor Author

3/27

@danehans danehans marked this pull request as draft March 26, 2025 05:10
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2025
@danehans
Copy link
Contributor Author

Marked as draft as i validate the steps in the getting started guide.

@danehans
Copy link
Contributor Author

#552 broke Kgateway integration. Waiting for kgateway-dev/kgateway#10921 to merge for the fix.

@danehans
Copy link
Contributor Author

I have verified this PR works after kgateway-dev/kgateway#10921 merges. I'm keeping as "draft" until Kgateway v2.0.0 is cut. I will then replace dev build references with v2.0.0.

If you are testing this PR in a cluster that does not support services of type LoadBalancer, do the following:

kubectl apply -f - <<EOF
apiVersion: gateway.kgateway.dev/v1alpha1
kind: GatewayParameters
metadata:
  name: kgateway
  namespace: kgateway-system
spec:
  kube:
    service:
      type: ClusterIP 
---
apiVersion: gateway.networking.k8s.io/v1
kind: GatewayClass
metadata:
  name: kgateway
spec:
  controllerName: kgateway.dev/kgateway
  description: kgateway controller
  parametersRef:
    group: gateway.kgateway.dev
    kind: GatewayParameters
    name: kgateway
    namespace: kgateway-system
EOF

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 29, 2025
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahg-g
Copy link
Contributor

ahg-g commented Mar 29, 2025

Can we close this now?

@danehans
Copy link
Contributor Author

Closing since #577 merged.

@danehans danehans closed this Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants