-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding getting started instructions for GKE, Istio, and Kgateway #577
Conversation
|
Welcome @nicolexin! |
Hi @nicolexin. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for gateway-api-inference-extension ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
Thanks @nicolexin! For KGateway: For Istio: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nicolexin!
site-src/guides/index.md
Outdated
1. If you run the Endpoint Picker (EPP) with TLS (with `--secureServing=true`), it is currently using a self-signed certificate | ||
and the gateway cannot successfully validate the CA signature and the SAN. Apply the destination rule to bypass verification as | ||
a temporary workaround. A better TLS implementation is being discussed in [Issue 582](https://github.com/kubernetes-sigs/gateway-api-inference-extension/issues/582). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@LiorLieberman My goal with the suggestion was to highlight that Istio's TLS verification is a positive/helpful feature. IMO, the only time neutral OSS docs should point out a shortcoming of an implementation is if that implementation is failing to do something required by the API, that's not the case here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work here @nicolexin! overall LGTM.
minor nits on some threads (nothing is actionable for now probably)
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nicolexin!
/lgtm
/assign kfswain |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, LiorLieberman, nicolexin, robscott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I did run through the guide with a GKE cluster end to end and I have no issues applying the ClusterRoleBinding and the vLLM deployments. |
Yeah, we mark a specific branch in our version branches. Granted that doesn't make it to our site (we only host main). We may need to break out version specific guides. Cut: #610
Interesting, I think that's just a validation error, and they RoleBinding should still exist afaik? I did omit
They work for me. I'm using A100s its possible we need to have a disclaimer that they are tuned for A100 machines. LMK |
Thanks @nicolexin!!! RIP xDS Surgery, you won't be missed :P |
Update inference extension getting started guide: