-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding simple cloudbuild file that builds, tags, and pushes the docker image #94
Conversation
Pairs with: kubernetes/test-infra#33930 |
Fixes #55 |
@@ -0,0 +1,15 @@ | |||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi, lws and jobset are slightly different: https://github.com/kubernetes-sigs/lws/blob/main/cloudbuild.yaml
not an expert on this file, so I am not sure if we need to do the same thing here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, they are using make
as their build command. We are just using a simple docker build
for now, so we are using a base image. I expect we will increase in sophistication as time goes on but this works for now I think. I've tested this on my personal GCP project's cloud build (I had to change the registry, but thats just permissioning issues)
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahg-g, kfswain The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
No description provided.