Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple cloudbuild file that builds, tags, and pushes the docker image #94

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

kfswain
Copy link
Collaborator

@kfswain kfswain commented Dec 11, 2024

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 11, 2024
@kfswain
Copy link
Collaborator Author

kfswain commented Dec 11, 2024

Pairs with: kubernetes/test-infra#33930

@kfswain
Copy link
Collaborator Author

kfswain commented Dec 11, 2024

Fixes #55

@@ -0,0 +1,15 @@
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, lws and jobset are slightly different: https://github.com/kubernetes-sigs/lws/blob/main/cloudbuild.yaml

not an expert on this file, so I am not sure if we need to do the same thing here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they are using make as their build command. We are just using a simple docker build for now, so we are using a base image. I expect we will increase in sophistication as time goes on but this works for now I think. I've tested this on my personal GCP project's cloud build (I had to change the registry, but thats just permissioning issues)

@ahg-g
Copy link
Contributor

ahg-g commented Dec 11, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahg-g, kfswain

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit e23aab7 into kubernetes-sigs:main Dec 11, 2024
2 checks passed
@kfswain kfswain deleted the cloudbuild branch January 23, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants