Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding simple cloudbuild file that builds, tags, and pushes the docker image #94

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Adding simple cloudbuild file that builds, tags, and pushes the docker image #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions cloudbuild.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi, lws and jobset are slightly different: https://github.com/kubernetes-sigs/lws/blob/main/cloudbuild.yaml

not an expert on this file, so I am not sure if we need to do the same thing here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, they are using make as their build command. We are just using a simple docker build for now, so we are using a base image. I expect we will increase in sophistication as time goes on but this works for now I think. I've tested this on my personal GCP project's cloud build (I had to change the registry, but thats just permissioning issues)

- name: gcr.io/cloud-builders/docker
args:
- build
- --tag=us-central1-docker.pkg.dev/k8s-staging-images/llm-instance-gateway:$_GIT_TAG
- .
substitutions:
_GIT_TAG: '12345'
# this prevents errors if you don't use both _GIT_TAG
# or any new substitutions added in the future.
options:
substitution_option: ALLOW_LOOSE
# this will push these images, or cause the build to fail if they weren't built.
images:
- 'us-central1-docker.pkg.dev/k8s-staging-images/llm-instance-gateway:$_GIT_TAG'