Skip to content

Enable VolumeAttributesClass feature gate for CI runs #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,5 @@ patchesJson6902:
kind: Deployment
name: csi-gce-pd-controller
version: v1
- path: driver-args.yaml
target:
group: apps
kind: Deployment
name: csi-gce-pd-controller
version: v1
transformers:
- ../../images/prow-stable-sidecar-rc-master
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# ControllerModifyVolume User Guide
# VolumeAttributesClass User Guide

>**Attention:** VolumeAttributesClass is a Kubernetes Beta feature since v1.31, but was initially introduced as an alpha feature in v1.29. See [this blog post](https://kubernetes.io/docs/concepts/storage/volume-attributes-classes/) for more information on VolumeAttributesClasses and how to enable the feature gate.

### ControllerModifyVolume Example
### VolumeAttributesClass Example

This example provisions a hyperdisk-balanced and then updates its IOPS and throughput.

Expand Down
3 changes: 3 additions & 0 deletions test/run-k8s-integration-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ fi

if [ "$test_volumeattributesclass" = true ]; then
base_cmd="${base_cmd} --volumeattributesclass-files=hdb-volumeattributesclass.yaml --storageclass-for-vac-file=sc-hdb.yaml --kube-runtime-config=api/all=true"
if [ "$deployment_strategy" = "gce" ]; then
base_cmd="${base_cmd} --kube-feature-gates=VolumeAttributesClass=true"
fi
fi

eval "$base_cmd"