-
Notifications
You must be signed in to change notification settings - Fork 159
Enable VolumeAttributesClass feature gate for CI runs #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @travisyx. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amacaskill, travisyx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.15 |
@travisyx: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.15 |
@amacaskill: #1838 failed to apply on top of branch "release-1.15":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
…ModifyVolume E2E tests kubernetes-sigs#1836: Create documentation for ControllerModifyVolume and controller default kubernetes-sigs#1838: Enable VolumeAttributesClass feature gate for CI runs kubernetes-sigs#1841: Update logic to use SI for VACs"
…ick-of-#1826-#1836-#1838-#1841-upstream-release-1.15 Revert "Automated cherry pick of #1826: Add ControllerModifyVolume E2E tests#1836: Create documentation for ControllerModifyVolume and controller default#1838: Enable VolumeAttributesClass feature gate for CI runs#1841: Update logic to use SI for VACs"
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR fixes an issue where the CI tests do not have the feature gate for VolumeAttributesClass set. Additionally, duplicate definitions for --supports-dynamic-iops-provisioning and --supports-dynamic-throughput-provisioning are removed now that the command line arguments are default. ControllerModifyVolume has been replaced with VolumeAttributesClass in the user guide for clarity purposes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: