Skip to content

Enable VolumeAttributesClass feature gate for CI runs #1838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

travisyx
Copy link
Contributor

@travisyx travisyx commented Sep 25, 2024

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

This PR fixes an issue where the CI tests do not have the feature gate for VolumeAttributesClass set. Additionally, duplicate definitions for --supports-dynamic-iops-provisioning and --supports-dynamic-throughput-provisioning are removed now that the command line arguments are default. ControllerModifyVolume has been replaced with VolumeAttributesClass in the user guide for clarity purposes.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 25, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 25, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @travisyx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 25, 2024
@amacaskill
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 26, 2024
@amacaskill
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amacaskill, travisyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2024
@k8s-ci-robot k8s-ci-robot merged commit a13019b into kubernetes-sigs:master Sep 26, 2024
7 checks passed
@travisyx
Copy link
Contributor Author

travisyx commented Nov 5, 2024

/cherry-pick release-1.15

@k8s-infra-cherrypick-robot

@travisyx: only kubernetes-sigs org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@amacaskill
Copy link
Member

/cherry-pick release-1.15

@k8s-infra-cherrypick-robot

@amacaskill: #1838 failed to apply on top of branch "release-1.15":

Applying: Enable VolumeAttributesClass feature gate for CI runs
Using index info to reconstruct a base tree...
A	deploy/kubernetes/overlays/prow-stable-sidecar-rc-master/driver-args.yaml
M	deploy/kubernetes/overlays/prow-stable-sidecar-rc-master/kustomization.yaml
M	test/run-k8s-integration-ci.sh
Falling back to patching base and 3-way merge...
Auto-merging test/run-k8s-integration-ci.sh
CONFLICT (content): Merge conflict in test/run-k8s-integration-ci.sh
CONFLICT (rename/delete): deploy/kubernetes/overlays/prow-stable-sidecar-rc-master/driver-args.yaml deleted in Enable VolumeAttributesClass feature gate for CI runs and renamed to deploy/kubernetes/overlays/dev/driver-args.yaml in HEAD. Version HEAD of deploy/kubernetes/overlays/dev/driver-args.yaml left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Enable VolumeAttributesClass feature gate for CI runs

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot added a commit that referenced this pull request Nov 5, 2024
…1836-#1838-#1841-upstream-release-1.15

Automated cherry pick of #1826: Add ControllerModifyVolume E2E tests
#1836: Create documentation for ControllerModifyVolume and controller default
#1838: Enable VolumeAttributesClass feature gate for CI runs
#1841: Update logic to use SI for VACs
travisyx added a commit to travisyx/gcp-compute-persistent-disk-csi-driver that referenced this pull request Nov 12, 2024
…ModifyVolume E2E tests

kubernetes-sigs#1836: Create documentation for ControllerModifyVolume and controller default
kubernetes-sigs#1838: Enable VolumeAttributesClass feature gate for CI runs
kubernetes-sigs#1841: Update logic to use SI for VACs"
amacaskill added a commit that referenced this pull request Nov 13, 2024
…ick-of-#1826-#1836-#1838-#1841-upstream-release-1.15

Revert "Automated cherry pick of #1826: Add ControllerModifyVolume E2E tests#1836: Create documentation for ControllerModifyVolume and controller default#1838: Enable VolumeAttributesClass feature gate for CI runs#1841: Update logic to use SI for VACs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants