Skip to content

log error if sign-file fails #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2023
Merged

log error if sign-file fails #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/signimage/signimage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ func processFile(filename string, header *tar.Header, tarreader io.Reader, data
//sign it
err = signFile(kmodsToSign[canonfilename], pubKeyFile, privKeyFile)
if err != nil {
return fmt.Errorf("error signing file %s", canonfilename)
return fmt.Errorf("error signing file %s: %v", canonfilename, err)
}
logger.Info("Signed successfully", "kmod", canonfilename)
return nil
Expand Down
2 changes: 0 additions & 2 deletions internal/sign/job/signer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,8 +176,6 @@ var _ = Describe("MakeJobTemplate", func() {
}
if imagePullSecret != nil {
mod.Spec.ImageRepoSecret = imagePullSecret
//expected.Spec.Template.Spec.Containers[0].Args = append(expected.Spec.Template.Spec.Containers[0].Args, "-secretdir")
//expected.Spec.Template.Spec.Containers[0].Args = append(expected.Spec.Template.Spec.Containers[0].Args, "/docker_config/")
expected.Spec.Template.Spec.Containers[0].VolumeMounts =
append(expected.Spec.Template.Spec.Containers[0].VolumeMounts,
v1.VolumeMount{
Expand Down