log error if sign-file fails #237
Conversation
the error from the sign-file binary was getting lost because it wasn't returned through the stack call correctly. This commit fixes that by passing the message up. Also remove a couple of commented out code lines.
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @chr15p. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
size/XS
Codecov ReportBase: 77.97% // Head: 77.97% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 77.97% 77.97%
=======================================
Files 27 27
Lines 2820 2820
=======================================
Hits 2199 2199
Misses 514 514
Partials 107 107 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chr15p, qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/lgtm |
k8s-ci-robot
added
the
lgtm
(this fixes a small discrepancy between upstream and midstream infavour of upstream) log error if sign-file fails (kubernetes-sigs#237) the error from the sign-file binary was getting lost because it wasn't returned through the stack call correctly. This commit fixes that by passing the message up. Also remove a couple of commented out code lines.
the error from the sign-file binary was getting lost because it wasn't returned through the stack call correctly. This commit fixes that by passing the message up.
Also remove a couple of commented out code lines. (these were picked up by downstream code review)