Skip to content

Fixing ci/prow/check-commit-count. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 6, 2022
Merged

Fixing ci/prow/check-commit-count. #28

merged 1 commit into from
Sep 6, 2022

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Sep 1, 2022 •
edited
Loading

Prow is cloning the repo using git clone --mirror ....

In addition to that, the changes are directly tested in the main
branch, therefore, the only way to get the diff is to add the upstream
remote and check the diff against upstream/main instead of main.

Signed-off-by: Yoni Bettan [email protected]

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @ybettan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 1, 2022
@qbarrand
Copy link
Contributor

qbarrand commented Sep 1, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 1, 2022
@ybettan ybettan force-pushed the fix-commit-count branch 15 times, most recently from dc2e0ce to e1f220a Compare September 1, 2022 13:58
@ybettan
Fixing ci/prow/check-commit-count.
beb2cce 
Prow is cloning the repo using `git clone --mirror ...`.

In addition to that, the changes are directly tested in the `main`
branch, therefore, the only way to get the diff is to add the `upstream`
remote and check the diff against `upstream/main` instead of `main`.

Signed-off-by: Yoni Bettan <[email protected]>
@ybettan
Copy link
Contributor Author

ybettan commented Sep 1, 2022

/hold
I tend to think that using the Github API via gh cli will be cleaner.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 1, 2022
@ybettan ybettan mentioned this pull request Sep 5, 2022
Closed
@ybettan
Copy link
Contributor Author

ybettan commented Sep 5, 2022

Here is another optional fix which I think is better and lay the infra for writing more complex jobs like checking the commits content before merging.

@qbarrand
Copy link
Contributor

qbarrand commented Sep 6, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand, ybettan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 6, 2022
@ybettan
Copy link
Contributor Author

ybettan commented Sep 6, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 6, 2022
@k8s-ci-robot k8s-ci-robot merged commit 78401c6 into kubernetes-sigs:main Sep 6, 2022
@ybettan ybettan deleted the fix-commit-count branch September 6, 2022 12:11
qbarrand referenced this pull request in qbarrand/kernel-module-management Sep 19, 2022
@fabiendupont @qbarrand
Add workflow steps to build bundle and catalog (#28)
fa7ada5 
When the operator image is updated, the bundle image needs to be updated
as well to reflect the new operator image digest. This change adds this
by calling `make bundle` and rebuilding / pushing the bundle image.

On the same line, the catalog image needs to be rebuilt to reflect the
new bundle image digest. This is also part of this change.

The `bundle` folder is also ignored since its content is generated and
uses the operator image digest, that changes with every merge.

There can be additional improvements to ensure digests are used
everywhere, but it's a first stab at automating the operator > bundle >
catalog flow.

Signed-off-by: Fabien Dupont <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbarrand qbarrand Awaiting requested review from qbarrand

@yevgeny-shnaidman yevgeny-shnaidman Awaiting requested review from yevgeny-shnaidman

Assignees

@qbarrand qbarrand

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ybettan @k8s-ci-robot @qbarrand