-
Notifications
You must be signed in to change notification settings - Fork 34
Updating ci/prow/check-commit-count to use the gh
cli.
#34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @ybettan. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ybettan: GitHub didn't allow me to request PR reviews from the following users: enriquebelarte. Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold |
Codecov ReportBase: 63.69% // Head: 72.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
+ Coverage 63.69% 72.90% +9.20%
==========================================
Files 25 16 -9
Lines 1840 1587 -253
==========================================
- Hits 1172 1157 -15
+ Misses 609 371 -238
Partials 59 59 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
8379882
to
966ae1d
Compare
/ok-to-test |
f1a1fe3
to
83836fc
Compare
/retest |
Prow is cloning the repo using `git clone --mirror ...`. In addition to that, the changes are directly tested in the `main` branch, therefore, the current implementation isn't working. Transitioning to the `gh` cli instead. Signed-off-by: Yoni Bettan <[email protected]>
83836fc
to
cc504a6
Compare
@ybettan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Seems like kubernetes/test-infra#27390 is not going to merge so I am closing this PR for now. |
Prow is cloning the repo using
git clone --mirror ...
.In addition to that, the changes are directly tested in the
main
branch, therefore, the current implementation isn't working.
Transitioning to the
gh
cli instead.Signed-off-by: Yoni Bettan [email protected]