Skip to content

Updating ci/prow/check-commit-count to use the gh cli. #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ybettan
Copy link
Contributor

@ybettan ybettan commented Sep 5, 2022

Prow is cloning the repo using git clone --mirror ....

In addition to that, the changes are directly tested in the main
branch, therefore, the current implementation isn't working.

Transitioning to the gh cli instead.

Signed-off-by: Yoni Bettan [email protected]

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 5, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ybettan
Once this PR has been reviewed and has the lgtm label, please assign zvonkok for approval by writing /assign @zvonkok in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @ybettan. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2022
@ybettan
Copy link
Contributor Author

ybettan commented Sep 5, 2022

@k8s-ci-robot
Copy link
Contributor

@ybettan: GitHub didn't allow me to request PR reviews from the following users: enriquebelarte.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @qbarrand @yevgeny-shnaidman @enriquebelarte

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ybettan
Copy link
Contributor Author

ybettan commented Sep 5, 2022

/hold
Should be merged after kubernetes/test-infra#27374 so the CI can make sure this test is working.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 5, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2022

Codecov Report

Base: 63.69% // Head: 72.90% // Increases project coverage by +9.20% 🎉

Coverage data is based on head (83836fc) compared to base (071840d).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
+ Coverage   63.69%   72.90%   +9.20%     
==========================================
  Files          25       16       -9     
  Lines        1840     1587     -253     
==========================================
- Hits         1172     1157      -15     
+ Misses        609      371     -238     
  Partials       59       59              
Impacted Files Coverage Δ
internal/auth/mock_auth.go
internal/daemonset/mock_daemonset.go
internal/build/job/mock_maker.go
internal/preflight/mock_preflight_api.go
internal/build/mock_manager.go
internal/module/mock_kernelmapper.go
internal/registry/mock_registry_api.go
internal/build/mock_helper.go
internal/statusupdater/mock_statusupdater.go

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yevgeny-shnaidman
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 6, 2022
@ybettan ybettan force-pushed the commits-count-gh-cli branch 2 times, most recently from f1a1fe3 to 83836fc Compare September 6, 2022 10:43
@ybettan
Copy link
Contributor Author

ybettan commented Sep 6, 2022

/retest

Prow is cloning the repo using `git clone --mirror ...`.

In addition to that, the changes are directly tested in the `main`
branch, therefore, the current implementation isn't working.

Transitioning to the `gh` cli instead.

Signed-off-by: Yoni Bettan <[email protected]>
@ybettan ybettan force-pushed the commits-count-gh-cli branch from 83836fc to cc504a6 Compare September 6, 2022 12:13
@k8s-ci-robot
Copy link
Contributor

@ybettan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kernel-module-management-check-commits-count cc504a6 link false /test pull-kernel-module-management-check-commits-count

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ybettan
Copy link
Contributor Author

ybettan commented Sep 7, 2022

Seems like kubernetes/test-infra#27390 is not going to merge so I am closing this PR for now.

@ybettan ybettan closed this Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants