Adding a prow script to test a basic deployment.
#353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
k8s-ci-robot
added
the
size/XS
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
=======================================
Coverage 82.92% 82.92%
=======================================
Files 27 27
Lines 2811 2811
=======================================
Hits 2331 2331
Misses 390 390
Partials 90 90 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This was referenced Mar 26, 2023
This test will make sure that steps added to the `e2e` workflow are not braking our deployment flow mentioned in kernel-module-management#getting-started or by using `make deploy` which are basically the same. A good example for it is to add a validation web-hook that requires the installation of `cert-manager` which should also be installed outside of the CI environment. Signed-off-by: Yoni Bettan <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ybettan
referenced
this pull request
in ybettan/kernel-module-management
Mar 28, 2023
This reverts commit 91e4bca.
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Jun 2, 2023
Improve push/pull secret handling in signing Re-work secret handling for pulling and pushing images Add support for dockerconfigjson and dockercfg style secrets Add support for multiple keys in a single secret (useful for pulling and pushing to different registries) This also sets the stage for allowing service account secrets We do this by mounting secrets in their own directories then reading all the files (keys) in that dir
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test will make sure that steps added to the
e2eworkflow are notbraking our deployment flow mentioned in
kernel-module-management#getting-started or by using
make deploywhichare basically the same.
A good example for it is to add a validation web-hook that requires the
installation of
cert-managerwhich should also be installed outside ofthe CI environment.