-
Notifications
You must be signed in to change notification settings - Fork 34
Revert "Adding a prow
script to test a basic deployment."
#357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Adding a prow
script to test a basic deployment."
#357
Conversation
This reverts commit 91e4bca.
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/retest |
@ybettan: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override pull-kernel-module-management-test-deploy |
Reverts #353
If someone breaks the deployment flow but inserting new dependencies and
decide that the "fix" is to install those dependencies manually in the
e2e test, then he will also probably install the dependency manually in
this test instead of adding the dependency installation to the
kustomization
overlay, therefore, this test doesn't have anyadditional value.