Refactor `internal/{api,module}` #364

qbarrand · 2023-03-29T09:44:32Z

Move MLD-related internal/module functions to internal/api.
Remove the KernelMapper type in favor of ModuleLoaderFactory.
Use ModuleLoaderData methods everywhere instead of internal/module functions.

/cc @mresvanis @yevgeny-shnaidman

k8s-ci-robot · 2023-03-29T09:44:38Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qbarrand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [qbarrand]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2023-03-29T09:44:38Z

✅ Deploy Preview for kubernetes-sigs-kmm ready!

Name	Link
🔨 Latest commit	`2858b8a`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/644a48ff0ac0940008e9f281
😎 Deploy Preview	https://deploy-preview-364--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

internal/utils/image/image.go

internal/api/moduleloaderdata.go

internal/cluster/cluster.go

internal/api/moduleloaderdata.go

qbarrand · 2023-03-29T13:14:27Z

@yevgeny-shnaidman PTAL.

internal/sign/job/signer.go

yevgeny-shnaidman · 2023-03-30T07:38:59Z

/lgtm

ybettan · 2023-03-30T08:08:58Z

internal/api/factory.go

+//go:generate mockgen -source=factory.go -package=api -destination=mock_factory.go ModuleLoaderDataFactory,moduleLoaderDataFactoryHelper
+
+type ModuleLoaderDataFactory interface {
+	FromModule(mod *kmmv1beta1.Module, kernelVersion string) (*ModuleLoaderData, error)


Do we plan to have other mlds rather then a module one? I am wondering why we need a factory if we only have 1 type.

I think that the name of the interface is a little bit confusing: usually factory means creating various other interface/objects and then using them. In this case it just means manifacturing ModuleLoaderData structure. It also threw me off the first time i saw the interface, until i looked at the rest of the code

Renamed to ModuleLoaderDataCreator.

yevgeny-shnaidman · 2023-03-30T10:25:19Z

internal/api/factory.go

+	mld.KernelVersion = kernelVersion
+	mld.Name = mod.Name
+	mld.Namespace = mod.Namespace
+	mld.ImageRepoSecret = mod.Spec.ImageRepoSecret


ImagePullPolicy also needs to be set here

yevgeny-shnaidman · 2023-03-30T10:25:46Z

/hold

k8s-ci-robot · 2023-04-25T11:56:15Z

New changes are detected. LGTM label has been removed.

qbarrand · 2023-04-25T12:12:28Z

@yevgeny-shnaidman @ybettan @mresvanis PTAL

cmd/manager/main.go

controllers/module_reconciler.go

Move MLD-related internal/module functions to internal/api. Remove the KernelMapper type in favor of ModuleLoaderCreator. Use ModuleLoaderData methods everywhere instead of internal/module functions.

yevgeny-shnaidman · 2023-04-30T10:09:30Z

internal/api/creator.go

+}
+
+type sectionGetter interface {
+	GetRelevantBuild(moduleBuild *kmmv1beta1.Build, mappingBuild *kmmv1beta1.Build) *kmmv1beta1.Build


those interface's methods can be private, they are not used anywhere outside of the package

yevgeny-shnaidman · 2023-04-30T10:12:25Z

internal/api/creator.go

+
+	mld := &ModuleLoaderData{}
+	// prepare the build
+	if mapping.Build != nil || mod.Spec.ModuleLoader.Container.Build != nil {


what do you think about moving the checks for kenrelMapping sign/buid and module sign/build into the getRelevantBuidl/Sign functions? This will make prepareModuleLoader code cleaner, and those functions are returning pointer anyway

k8s-ci-robot · 2023-05-03T12:06:36Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

(this fixes a small discrepancy between upstream and midstream infavour of upstream) log error if sign-file fails (kubernetes-sigs#237) the error from the sign-file binary was getting lost because it wasn't returned through the stack call correctly. This commit fixes that by passing the message up. Also remove a couple of commented out code lines.

k8s-triage-robot · 2024-01-19T01:57:03Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-18T02:00:13Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-03-19T02:45:59Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-03-19T02:46:05Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from mresvanis and yevgeny-shnaidman March 29, 2023 09:44

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 29, 2023

qbarrand force-pushed the refactor-mld branch from 8f39264 to 1d5615e Compare March 29, 2023 09:56

qbarrand mentioned this pull request Mar 29, 2023

Refactor build / sign managers #361

Closed

qbarrand changed the title ~~Refactor internal/{api,module}~~ Refactor internal/{api,module} Mar 29, 2023

yevgeny-shnaidman reviewed Mar 29, 2023

View reviewed changes

internal/utils/image/image.go Show resolved Hide resolved

internal/api/moduleloaderdata.go Outdated Show resolved Hide resolved

internal/cluster/cluster.go Show resolved Hide resolved

internal/api/moduleloaderdata.go Show resolved Hide resolved

qbarrand force-pushed the refactor-mld branch from 1d5615e to 329f4f3 Compare March 29, 2023 13:13

yevgeny-shnaidman reviewed Mar 29, 2023

View reviewed changes

internal/sign/job/signer.go Show resolved Hide resolved

k8s-ci-robot assigned yevgeny-shnaidman Mar 30, 2023

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 30, 2023

ybettan reviewed Mar 30, 2023

View reviewed changes

yevgeny-shnaidman reviewed Mar 30, 2023

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 30, 2023

qbarrand force-pushed the refactor-mld branch from 329f4f3 to 3272f23 Compare April 25, 2023 11:56

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 25, 2023

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 25, 2023

qbarrand force-pushed the refactor-mld branch from 3272f23 to 59e37bb Compare April 25, 2023 12:12

ybettan reviewed Apr 27, 2023

View reviewed changes

cmd/manager/main.go Outdated Show resolved Hide resolved

ybettan reviewed Apr 27, 2023

View reviewed changes

controllers/module_reconciler.go Outdated Show resolved Hide resolved

ybettan reviewed Apr 27, 2023

View reviewed changes

controllers/module_reconciler.go Outdated Show resolved Hide resolved

ybettan reviewed Apr 27, 2023

View reviewed changes

controllers/module_reconciler.go Outdated Show resolved Hide resolved

Refactor internal/{api,module}

2858b8a

Move MLD-related internal/module functions to internal/api. Remove the KernelMapper type in favor of ModuleLoaderCreator. Use ModuleLoaderData methods everywhere instead of internal/module functions.

qbarrand force-pushed the refactor-mld branch from 59e37bb to 2858b8a Compare April 27, 2023 10:05

yevgeny-shnaidman reviewed Apr 30, 2023

View reviewed changes

qbarrand mentioned this pull request May 2, 2023

Use OpenShift builds for signing rh-ecosystem-edge/kernel-module-management#499

Merged

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024

k8s-ci-robot closed this Mar 19, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor `internal/{api,module}` #364

Refactor `internal/{api,module}` #364

qbarrand commented Mar 29, 2023

k8s-ci-robot commented Mar 29, 2023

netlify bot commented Mar 29, 2023 •

edited

Loading

qbarrand commented Mar 29, 2023

yevgeny-shnaidman commented Mar 30, 2023

ybettan Mar 30, 2023

yevgeny-shnaidman Mar 30, 2023 •

edited

Loading

qbarrand Apr 25, 2023

yevgeny-shnaidman Mar 30, 2023

qbarrand Apr 25, 2023

yevgeny-shnaidman commented Mar 30, 2023

k8s-ci-robot commented Apr 25, 2023

qbarrand commented Apr 25, 2023

yevgeny-shnaidman Apr 30, 2023

yevgeny-shnaidman Apr 30, 2023

k8s-ci-robot commented May 3, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

k8s-triage-robot commented Mar 19, 2024

k8s-ci-robot commented Mar 19, 2024

Refactor internal/{api,module} #364

Refactor internal/{api,module} #364

Conversation

qbarrand commented Mar 29, 2023

k8s-ci-robot commented Mar 29, 2023

netlify bot commented Mar 29, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-kmm ready!

qbarrand commented Mar 29, 2023

yevgeny-shnaidman commented Mar 30, 2023

ybettan Mar 30, 2023

Choose a reason for hiding this comment

yevgeny-shnaidman Mar 30, 2023 • edited Loading

Choose a reason for hiding this comment

qbarrand Apr 25, 2023

Choose a reason for hiding this comment

yevgeny-shnaidman Mar 30, 2023

Choose a reason for hiding this comment

qbarrand Apr 25, 2023

Choose a reason for hiding this comment

yevgeny-shnaidman commented Mar 30, 2023

k8s-ci-robot commented Apr 25, 2023

qbarrand commented Apr 25, 2023

yevgeny-shnaidman Apr 30, 2023

Choose a reason for hiding this comment

yevgeny-shnaidman Apr 30, 2023

Choose a reason for hiding this comment

k8s-ci-robot commented May 3, 2023

k8s-triage-robot commented Jan 19, 2024

k8s-triage-robot commented Feb 18, 2024

k8s-triage-robot commented Mar 19, 2024

k8s-ci-robot commented Mar 19, 2024

Refactor `internal/{api,module}` #364

Refactor `internal/{api,module}` #364

netlify bot commented Mar 29, 2023 •

edited

Loading

yevgeny-shnaidman Mar 30, 2023 •

edited

Loading