Move controllers to internal/controllers
#519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qbarrand The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-kmm ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/L
qbarrand
force-pushed
the
refactor-controllers
branch
from
94bd30a to
fd50e1b
Compare
qbarrand
changed the title
controllers to internal/controllers
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #519 +/- ##
==========================================
- Coverage 80.24% 80.00% -0.24%
==========================================
Files 43 43
Lines 4439 4446 +7
==========================================
- Hits 3562 3557 -5
- Misses 720 732 +12
Partials 157 157
☔ View full report in Codecov by Sentry. |
|
/lgtm |
k8s-ci-robot
added
lgtm
Rename NodeModulesConfigReconciler to NMCReconciler. Use private interfaces for the NMCReconciler for consistency.
qbarrand
force-pushed
the
refactor-controllers
branch
from
fd50e1b to
718405b
Compare
k8s-ci-robot
removed
lgtm
|
@yevgeny-shnaidman PTAL |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
added a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Nov 8, 2023
…netes-sigs#715) Rename NodeModulesConfigReconciler to NMCReconciler. Use private interfaces for the NMCReconciler for consistency. Upstream-Commit: 7e339cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename
NodeModulesConfigReconcilertoNMCReconciler.Use private interfaces for the
NMCReconcilerfor consistency./cc @yevgeny-shnaidman