Skip to content

Adding support for loading multiple kernel modules(softdep) #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

yevgeny-shnaidman
Copy link
Contributor

No description provided.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yevgeny-shnaidman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 4, 2023
@netlify
Copy link

netlify bot commented Sep 4, 2023

Deploy Preview for kubernetes-sigs-kmm ready!

Name Link
🔨 Latest commit bb3c423
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kmm/deploys/64f83a52c95dd30007bcc490
😎 Deploy Preview https://deploy-preview-549--kubernetes-sigs-kmm.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 4, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18% 🎉

Comparison is base (f0cb9a0) 79.63% compared to head (be065ff) 79.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #549      +/-   ##
==========================================
+ Coverage   79.63%   79.82%   +0.18%     
==========================================
  Files          43       43              
  Lines        4316     4356      +40     
==========================================
+ Hits         3437     3477      +40     
  Misses        721      721              
  Partials      158      158              
Files Changed Coverage Δ
internal/controllers/nmc_reconciler.go 75.37% <100.00%> (+1.76%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qbarrand qbarrand linked an issue Sep 4, 2023 that may be closed by this pull request
@qbarrand
Copy link
Contributor

qbarrand commented Sep 6, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 6, 2023
@k8s-ci-robot k8s-ci-robot merged commit 08dabd7 into kubernetes-sigs:main Sep 6, 2023
qbarrand pushed a commit to qbarrand/kernel-module-management that referenced this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for soft dependencies
4 participants