Improving some comment on the 'check-commit-count' job. #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yoni Bettan <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ybettan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Codecov ReportBase: 73.43% // Head: 73.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 73.43% 73.23% -0.21%
==========================================
Files 16 16
Lines 1615 1670 +55
==========================================
+ Hits 1186 1223 +37
- Misses 372 388 +16
- Partials 57 59 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Sep 19, 2022
To be able to add more test-cases, we need to use a mock for the client interface. We do so using the 'gomock' library. This PR replaces the fake.Client in favor of using the new auto-generated mock based on the Client interface. MGMT-10532
qbarrand
pushed a commit
to qbarrand/kernel-module-management
that referenced
this pull request
Jun 2, 2023
To be able to add more test-cases, we need to use a mock for the client interface. We do so using the 'gomock' library. This PR replaces the fake.Client in favor of using the new auto-generated mock based on the Client interface. MGMT-10532
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yoni Bettan [email protected]