Add check-commits-count #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enriquebelarte The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @ybettan |
ybettan
reviewed
Nov 6, 2022
|
Latest update for u/s code: kubernetes-sigs/kernel-module-management#69 |
yevgeny-shnaidman
pushed a commit
to yevgeny-shnaidman/kernel-module-management
that referenced
this pull request
Nov 6, 2022
…stem-edge#88) The name of the image to build is assumed to be km.ContainerImage in several places in the code, this commit centralises that assumption into a single point in Reconcile(). In the future this will allow us to determine the image the stage produces once E.g if we add signing (or other) intermediate stages to the image build process.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Nov 6, 2022
The name of the image to build is assumed to be km.ContainerImage in several places in the code, this commit centralises that assumption into a single point in Reconcile(). In the future this will allow us to determine the image the stage produces once E.g if we add signing (or other) intermediate stages to the image build process. Co-authored-by: Chris Procter <[email protected]>
Add script to check that each PR consists of one single commit.
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add script to check that each PR consists of one single commit.