✨ Add flag for ignore-not-found to make undeploy

[perdasilva]

Description

This PR adds the possibility to pass --ignore-not-found to underlying kubectl delete command that gets executed by make undeploy. With this change, you can do make undeploy ignore-not-found=true. This way, if you have any errors in your kustomize your make undeploy or make uninstall won't error out when it stumbles on the missing resource.

Motivation

This is in response to the following issue from the operator-sdk project: operator-framework/operator-sdk#5195. Once incorporated downstream, it should address the same issue, at least for go scaffolds.

Notes

I'm not sure this is the best approach, or name for the environment variable. Happy to get some feedback there and make adjustments as necessary ^^

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @perdasilva!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @perdasilva. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[camilamacedo86]

What do you think about instead create an ENV VAR here we do something like:

action:
    echo argument is $(argument)
You would then call it make action argument=something

Also, would be nice add the info that args can be informed at the end in the comment ## Undeploy controller from the K8s cluster specified in ~/.kube/config.�. Why? That is the description of the target when we run make --help.

Also, it would allow people to pass any arg instead of an specific one and would remove the need to use and doc env vars.

[camilamacedo86]

/ok-to-test

[perdasilva]

I'm still not sure how to deal with defaults in this case, though. What do you think about something like:

ifndef ignore-not-found
  ignore-not-found = no
endif

undeploy: ## Undeploy controller from the K8s cluster specified in ~/.kube/config. Call with ignore-not-found=true to ignore resource not found errors during deletion.
    $(KUSTOMIZE) build config/default | kubectl delete --ignore-not-found=$(ignore-not-found) -f -

[perdasilva]

@camilamacedo86 I've updated the code with my suggestion and also spread it to the uninstall target. Seemed to make sense.

[camilamacedo86]

/approved

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[perdasilva]

/retest

[perdasilva]

/retest

[perdasilva]

@camilamacedo86 @joelanford could I get a /lgtm plz =)

[camilamacedo86]

@perdasilva
Could you please rebase with master and run make generate ?
It will allow us to merge this one.

[perdasilva]

@perdasilva Could you please rebase with master and run make generate ? It will allow us to merge this one.

@camilamacedo86 done ^^

[camilamacedo86]

/lgtm