Skip to content

Add --ignore-not-found=true to scaffolded undeploy make target #5195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
asmacdo opened this issue Sep 9, 2021 · 7 comments
Open

Add --ignore-not-found=true to scaffolded undeploy make target #5195

asmacdo opened this issue Sep 9, 2021 · 7 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. language/ansible Issue is related to an Ansible operator project language/go Issue is related to a Go operator project language/helm Issue is related to a Helm operator project lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Backlog

Comments

@asmacdo
Copy link
Member

asmacdo commented Sep 9, 2021 •
edited
Loading

Feature Request

While deploying the objects in config/ with kustomize, sometimes it goes wrong (user error) and not all the objects are created. When this happens, make undeploy fails on the first object that doesn't exist. Its easy to work around, just delete them manually. However this interrupts development flow and is a bit annoying.

If we add --ignore-not-found, make undeploy will always try to delete all the objects.

/language go
/language ansible
/language helm
@openshift-ci openshift-ci bot added language/go Issue is related to a Go operator project language/ansible Issue is related to an Ansible operator project language/helm Issue is related to a Helm operator project labels Sep 9, 2021
@jberkhahn jberkhahn assigned asmacdo and unassigned asmacdo Sep 13, 2021
@jberkhahn jberkhahn added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Sep 13, 2021
@jberkhahn jberkhahn added this to the Backlog milestone Sep 13, 2021
@perdasilva perdasilva mentioned this issue Sep 17, 2021
Merged
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 12, 2021
@camilamacedo86
Copy link
Contributor

It was added to Golang: https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v3/memcached-operator/Makefile#L118-L120

We still need to update the Makefile for Ansible/Helm and the new Go+Helm plugin.

c/c @asmacdo @fabianvf @varshaprasad96

@camilamacedo86
Copy link
Contributor

/lifecycle frozen

@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 12, 2022
@asmacdo
Copy link
Member Author

asmacdo commented Jan 12, 2022

/lifecycle frozen

@openshift-ci openshift-ci bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Jan 12, 2022
@camilamacedo86
Copy link
Contributor

Done for GO: https://github.com/operator-framework/operator-sdk/blob/master/testdata/go/v3/memcached-operator/Makefile#L126-L128 because of the KB bump

Missing update the Ansible/Helm dockerfile boilerplate only

@ashutosh887
Copy link

Let me know if any work needs to be done on this issue @camilamacedo86
I see it's a Good First Issue

@sgaist sgaist mentioned this issue Oct 12, 2024
Open
2 tasks
sgaist added a commit to sgaist/ansible-operator-plugins that referenced this issue Oct 12, 2024
@sgaist
scripts: add ignore-not-found for undeploy and uninstall to Makefile …
6546522 
…boiler plate

This avoid failure of any of these two commands if for some
reason one or more of the kustomized resource is missing.

Part of operator-framework/operator-sdk#5195

Signed-off-by: Samuel Gaist <[email protected]>
@sgaist sgaist mentioned this issue Oct 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. language/ansible Issue is related to an Ansible operator project language/go Issue is related to a Go operator project language/helm Issue is related to a Helm operator project lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
5 participants
@asmacdo @openshift-bot @jberkhahn @camilamacedo86 @ashutosh887