Update translations from Weblate #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
8668125 to
c33b03c
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
81ea8e1 to
c201ce8
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
c201ce8 to
dea3b83
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
9ea4a6b to
2a2ff87
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2a2ff87 to
55f30ff
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
55f30ff to
2cd3f29
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
2cd3f29 to
323e644
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
323e644 to
47dba8f
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
47dba8f to
9c07851
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9c07851 to
9fd7387
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
9fd7387 to
77a4794
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
2 times, most recently
from
d3a2722 to
bf2e154
Compare
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
bf2e154 to
a71a9ce
Compare
This way there's nothing that needs to happen at the bottom of the loop, if any of the cases matched.
Conveniently, the two redundant rules say the exact same thing when they apply. So the first one has no effect, and we can ignore it.
Before this change, all cases of this switch statement either continue the loop, or throw, or set classFound to true. The error therefore gets logged just if none of the cases matched. So we can express the same behavior with a default case.
This makes the reasoning about these index values more local.
Like an early return, this (a) brings the consequence of the error immediately next to the condition defining it, and (b) lets the normal happy case continue vertically down without adding indentation.
Same motivation as in the parent commit.
Once the parsing is done, we want these to remain unchanged, just like the other objects in the parse tree. So, like ContentNode and its subclasses, make the class immutable. The parser needs to mutate its own draft of what styles to apply to a given span; but it can do that with its own local variables corresponding to the fields, and construct a styles object at the end of the loop.
This deduplicates the logic for the particular way that a list of KaTeX nodes get combined into a single widget.
This makes it more uniform with our other content widgets.
And factor out a helper for the part that reads `widget.narrow` and sets a new controller accordingly; we'll use this helper for the edit-message UI, to reset the compose box at the end of an edit-message session. Fixes: zulip#1470
Taken from Figma: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=56-11686&m=dev There was a different "edit" icon on the Icons page: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=557-24893&m=dev but I chose this one because it's the one used in the design for the edit-message button: https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3988-35243&m=dev
Soon we'll want a method for starting a message-edit session, and it'll make sense to put it on ComposeBoxState rather than ComposeBoxController; one reason is that it'll need UI code to show an error dialog. With this change, the ComposeBoxState -- and so that new method -- will be accessible in the message-list widget code, where we open the message action sheet from.
When a subscription is removed, the data in streams and streamsByName are left as instances of `Subscription`. This is inconsistent with the data store's assumption that unsubscribed channels should have plain `ZulipStream` instances. This doesn't seem to have user-facing effects, though. The assertion errors only affect debug builds. CZO discussion: https://chat.zulip.org/#narrow/channel/48-mobile/topic/Unsubscribe.20then.20resubscribe.20to.20channel/with/2160241
github-actions
bot
force-pushed
the
update-translations/weblate
branch
from
a71a9ce to
fddb2e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action