Support for jsonb array comparision for $in $nin operator #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
reviewed
Jun 5, 2024
| @@ -203,11 +203,31 @@ | |||
| {"name": {"$in": ["adam", "bob"]}}, | |||
| [1, 2], | |||
| ), | |||
| ( | |||
| {"tags": {"$in": ["c", "d"]}}, | |||
There was a problem hiding this comment.
eyurtsev
requested changes
Jun 10, 2024
There was a problem hiding this comment.
- The change introduces a bug when working with numeric fields.
- If we wanted to support array comparison, we need to define clear semantics for Any vs. All. I suspect more users will expect the functionality to be All rather than Any. We can introduce a separate operator for that purpose.
| @@ -701,9 +701,15 @@ def _handle_field_filter( | |||
| queried_field = self.EmbeddingStore.cmetadata[field].astext | |||
|
|
|||
| if operator in {"$in"}: | |||
| return queried_field.in_([str(val) for val in filter_value]) | |||
| return func.jsonb_exists_any( | |||
There was a problem hiding this comment.
This change will result in a bug when working with integer fields which is a more common use case.
Adding a unit-test in a separate PR and will rebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current we are not able to check whether the jsonb array includes a value within a list. Likewise for checking array does not include any value in target list.