Skip to content

[9.x] Update Bootstrap pagination style #36468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[9.x] Update Bootstrap pagination style #36468

wants to merge 1 commit into from

Conversation

jrd-lewis
Copy link
Contributor

Rebase of #36467 onto the master branch instead the 8.x branch.

This PR updates Laravel's built-in Bootstrap pagination (bootstrap-4.blade.php) to be styled similarly to the built-in Tailwind pagination (tailwind.blade.php).

bootstrap-pagination

@jrd-lewis jrd-lewis changed the title Update Bootstrap pagination style [9.x] Update Bootstrap pagination style Mar 4, 2021
@jrd-lewis
Copy link
Contributor Author

@driesvints @GrahamCampbell Based on the earlier conversation, should I update the Bootstrap 3 pagination too?

@driesvints
Copy link
Member

driesvints commented Mar 4, 2021

@jrd-lewis let's see what Taylor says first.

@taylorotwell
Copy link
Member

While I appreciate the effort - I'm not sure the breaking change is worth it. Users can already export these views and customize them how they wish. If we do this it could potentially break people's frontends when they upgrade.

@jrd-lewis
Copy link
Contributor Author

@driesvints @taylorotwell With laravel/ui#212 being merged into the Laravel/UI package should we revisit this PR or perhaps start a new PR to register it as being specific to Bootstrap 5 pagination?

@driesvints
Copy link
Member

@jrd-lewis it seems Taylor doesn't wants to do the breaking change but indeed maybe with that PR it's different now. I'd attempt it again to see if he might merge it now. Try sending it in to 9.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants