Skip to content

Update Monitor Persistence Docs with Async Specifics #1684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #2394
TheBlueMatt opened this issue Aug 25, 2022 · 1 comment
Closed
Tracked by #2394

Update Monitor Persistence Docs with Async Specifics #1684

TheBlueMatt opened this issue Aug 25, 2022 · 1 comment
Milestone
0.1

Comments

@TheBlueMatt
Copy link
Collaborator

In #1106 various suggestions for clearer docs came up repeatedly, most of which depended on us actually properly supporting fully async persistence, which was previously considered unsafe. Once we do support fully async persistence, we should go back through those suggestions and, yet again, rewrite all the docs on the persistence status enum and chain::Watch.
@TheBlueMatt TheBlueMatt added this to the 0.1 milestone Aug 25, 2022
@TheBlueMatt TheBlueMatt mentioned this issue Mar 1, 2023
Closed
@TheBlueMatt
Copy link
Collaborator Author

Note from #1792 - make sure the docs we end up with for fully-async monitor persistence mention that updates must be persisted in the order they're generated in.

@ConorOkus ConorOkus mentioned this issue Jul 5, 2023
Closed
7 tasks
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 8, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
6494cd4 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 10, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
f6d63ea 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 14, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
6e4f8fa 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 15, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
787baff 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 19, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
47511eb 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 19, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
d948be6 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 20, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
825730d 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 21, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
d88f086 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 21, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
036e0b5 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 21, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
044fe69 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
TheBlueMatt added a commit to TheBlueMatt/rust-lightning that referenced this issue Sep 21, 2023
@TheBlueMatt
Update ChannelMonitorUpdateStatus documentation with async support
8d81193 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
dunxen pushed a commit to dunxen/rust-lightning that referenced this issue Sep 26, 2023
@TheBlueMatt @dunxen
Update ChannelMonitorUpdateStatus documentation with async support
db5ccc3 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
slanesuke pushed a commit to slanesuke/rust-lightning that referenced this issue Oct 6, 2023
@TheBlueMatt @slanesuke
Update ChannelMonitorUpdateStatus documentation with async support
b62f772 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
optout21 pushed a commit to optout21/rust-lightning that referenced this issue Nov 4, 2023
@TheBlueMatt @optout21
Update ChannelMonitorUpdateStatus documentation with async support
7d5eee2 
Since we now (almost) support async monitor update persistence, the
documentation on `ChannelMonitorUpdateStatus` can be updated to no
longer suggest users must keep a local copy that persists before
returning. However, because there are still a few remaining issues,
we note that async support is currently beta and explicily warn of
potential for funds-loss.

Fixes lightningdevkit#1684
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1
Development

No branches or pull requests
1 participant
@TheBlueMatt