Skip to content

[Clarity] Minor Docs #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
G8XSU opened this issue Oct 21, 2022 · 8 comments
Closed

[Clarity] Minor Docs #1792

G8XSU opened this issue Oct 21, 2022 · 8 comments
Assignees

Comments

@G8XSU
Copy link
Contributor

G8XSU commented Oct 21, 2022

  • In ChannelManager we have to wait for initial sync to complete. (clarity)
  • Monitor Updates need to be persisted in sequential fashion (specially when async) (clarity)
@G8XSU G8XSU added this to the 0.0.113 milestone Oct 21, 2022
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.113, 0.0.114 Dec 14, 2022
@TheBlueMatt
Copy link
Collaborator

Slipping to 114, not sure why this has a 113 tag if it wasnt assigned to anyone.

@dunxen
Copy link
Contributor

dunxen commented Feb 28, 2023

Are we moving this to 115? I can take it if I know where we should be clarifying the above to make it obvious to the user.

@TheBlueMatt
Copy link
Collaborator

Yea, I'm honestly not sure what the first one refers to. The second is kinda implied by docs today, but we definitely need to include it when we rewrite docs for fully-async monitor updates. Will note it in #1684.

@G8XSU can you suggest something concrete for the first bullet? Either way 114 doesnt need to wait on this.

@G8XSU
Copy link
Contributor Author

G8XSU commented Mar 9, 2023

I think both points are based on feedback from Lexe,
and first bullet means, ChannelManager and monitors need to be fully synced before client starts using channel-manager api's (including block-sync).

@TheBlueMatt TheBlueMatt added this to the 0.0.117 milestone Jul 4, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.117, 0.0.118 Aug 31, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.118, 0.0.119 Oct 12, 2023
@TheBlueMatt
Copy link
Collaborator

@G8XSU mind opening a PR for this?

@G8XSU
Copy link
Contributor Author

G8XSU commented Nov 5, 2023

Ok.. will do :)

@TheBlueMatt TheBlueMatt modified the milestones: 0.0.119, 0.0.120 Nov 28, 2023
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.120 , 0.0.121 Jan 9, 2024
@TheBlueMatt TheBlueMatt modified the milestones: 0.0.122, 0.0.123 Mar 18, 2024
@TheBlueMatt
Copy link
Collaborator

@G8XSU any update?

@TheBlueMatt
Copy link
Collaborator

Don't think there's anything left for this after #2992.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants