Skip to content

DocClarity: Chainsync ChannelManager before any operation #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

G8XSU
Copy link
Contributor

@G8XSU G8XSU commented Apr 12, 2024

As part of #1792

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (1d2a27d) to head (baa8ec8).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2994      +/-   ##
==========================================
- Coverage   89.40%   89.37%   -0.03%     
==========================================
  Files         117      117              
  Lines       96016    96016              
  Branches    96016    96016              
==========================================
- Hits        85842    85818      -24     
- Misses       7957     7978      +21     
- Partials     2217     2220       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheBlueMatt
Copy link
Collaborator

Is this unclear in the ChannelManagerReadArgs documentation? The sentence prior references seeing the ChannelManagerReadArgs as the authoritative source for what you need to do, and just including one of the several things in there doesn't seem like its adding a lot of clarity.

@G8XSU
Copy link
Contributor Author

G8XSU commented Apr 15, 2024

I agree that ChannelManagerReadArgs is authoritative source,
earlier i thought it only mentions channelManager chainsync, but I noticed it mentions both channelmanager and channelMonitor to be synced.

There is also a note on "must occur before you call any other methods on the newly-deserialized [ChannelManager]"

I am good with closing this PR as redundant.

@G8XSU G8XSU closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants