Skip to content

Bump LLVM #958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2022
Merged

Bump LLVM #958

merged 1 commit into from
Jun 23, 2022

Conversation

makslevental
Copy link
Collaborator

Bufferization dialect added a new useful op (bufferization.alloc_tensor) so how about a bump?

@makslevental makslevental requested a review from silvasean June 21, 2022 06:19
@makslevental
Copy link
Collaborator Author

hmm gotta adjust some of the filecheck tests...

// CHECK: %[[INT3:.*]] = torch.constant.int 3
// CHECK: %[[INTM1:.*]] = torch.constant.int -1
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what would lead to an inversion in the ordering here but don't think it's significant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happens from time to time as the pattern rewriters change under the hood

Copy link
Contributor

@silvasean silvasean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bump!

@makslevental makslevental merged commit 829717c into llvm:main Jun 23, 2022
@makslevental makslevental deleted the bumpllvm2 branch June 23, 2022 03:23
makslevental added a commit that referenced this pull request Jun 23, 2022
This reverts commit 829717c.
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 12, 2022
gpetters94 pushed a commit to gpetters94/mlir-npcomp that referenced this pull request Jul 27, 2022
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
check-onnx-backend-dynamic, etc., in serial. While we do
parallelize within each test set, we don't get much benefit
from it. Because within each test set, most of the time was
spent on one or two long running tests. While waiting for
these long running tests, we could have started the other
test sets.

This patch parallelizes across tests sets by starting them
all at once so the long running tests from different test
sets can run in parallel.

CompilerLib tests are disabled because a bug has been uncovered
that it was actually still using onnx-mlir instead of CompilerLibTest
to compile the models. Fix the bug to use CompilerLibTest and
it fails to compile the models.

Use CTEST_PARALLEL_LEVEL for numerical tests to be compatible
with Windows CI

Signed-off-by: Gong Su <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
qedawkins pushed a commit to nod-ai/torch-mlir that referenced this pull request Oct 3, 2022
… errors by assertion. (llvm#968)

* Conversion support (llvm#956)

* initial

Signed-off-by: Alexandre Eichenberger <[email protected]>

* works, bool is great, but unsigned create issues

Signed-off-by: Alexandre Eichenberger <[email protected]>

* added support to remove the UnrealizedConversionCastOp while lowering to llvm

Signed-off-by: Alexandre Eichenberger <[email protected]>

* last version to support some shaped type in conversion, reduce after to Integer or Float

Signed-off-by: Alexandre Eichenberger <[email protected]>

* converted to cast scalar only

Signed-off-by: Alexandre Eichenberger <[email protected]>

* added lit tests

Signed-off-by: Alexandre Eichenberger <[email protected]>

* update

Signed-off-by: Alexandre Eichenberger <[email protected]>

* initial

Signed-off-by: Alexandre Eichenberger <[email protected]>

* works, bool is great, but unsigned create issues

Signed-off-by: Alexandre Eichenberger <[email protected]>

* added support to remove the UnrealizedConversionCastOp while lowering to llvm

Signed-off-by: Alexandre Eichenberger <[email protected]>

* last version to support some shaped type in conversion, reduce after to Integer or Float

Signed-off-by: Alexandre Eichenberger <[email protected]>

* converted to cast scalar only

Signed-off-by: Alexandre Eichenberger <[email protected]>

* added lit tests

Signed-off-by: Alexandre Eichenberger <[email protected]>

* update

Signed-off-by: Alexandre Eichenberger <[email protected]>

* implemented cast with index, before replacing usage

Signed-off-by: Alexandre Eichenberger <[email protected]>

* update

Signed-off-by: Alexandre Eichenberger <[email protected]>

* cleanup and use of createMath constant/constantIndex/cast/castIndex

Signed-off-by: Alexandre Eichenberger <[email protected]>

* make sure that only explicitly unsigned are treated as unsigned; signless and indices are treated as signed

Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Add the onnx-mlir logo to the onnxai webpage (llvm#959)

* Add the onnx-mlir logo to the onnxai webpage

Signed-off-by: Tung D. Le <[email protected]>

* Remove a dump()

Signed-off-by: Tung D. Le <[email protected]>

* Missing git-add the .png file

Signed-off-by: Tung D. Le <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Several small improvements including adding onnx-mlir-doc to ALL target and building onnx from the submodule (llvm#957)

1. Add onnx-mlir-doc to the ALL target. This way it will be run with the default target
2. On Windows instead of installing onnx from pip, build it from source to match other CIs
3. Remove unnecessary include in Compiler

Signed-off-by: Stella Stamenova <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* fix the mistake of shape in doc-example (llvm#964)

Signed-off-by: david.cheng <[email protected]>

Co-authored-by: david.cheng <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* install dll to bin (llvm#963)

Signed-off-by: Michael Holman <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Output better error messages for file opening errors.

Signed-off-by: Yasushi Negishi <[email protected]>

* Fix clang-format errors

Signed-off-by: Yasushi Negishi <[email protected]>

* Fix build errors.

Signed-off-by: Yasushi Negishi <[email protected]>

* Fix a build error

Signed-off-by: Yasushi Negishi <[email protected]>

* Onehot update (llvm#967)

* initial commit

Signed-off-by: Alexandre Eichenberger <[email protected]>

* one hot upgraded, more dyn cases

Signed-off-by: Alexandre Eichenberger <[email protected]>

* cleanup

Signed-off-by: Alexandre Eichenberger <[email protected]>

* cleanup

Signed-off-by: Alexandre Eichenberger <[email protected]>

* initial commit

Signed-off-by: Alexandre Eichenberger <[email protected]>

* one hot upgraded, more dyn cases

Signed-off-by: Alexandre Eichenberger <[email protected]>

* cleanup

Signed-off-by: Alexandre Eichenberger <[email protected]>

* cleanup

Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* We currently run a few test sets, e.g., check-onnx-backend, (llvm#958)

check-onnx-backend-dynamic, etc., in serial. While we do
parallelize within each test set, we don't get much benefit
from it. Because within each test set, most of the time was
spent on one or two long running tests. While waiting for
these long running tests, we could have started the other
test sets.

This patch parallelizes across tests sets by starting them
all at once so the long running tests from different test
sets can run in parallel.

CompilerLib tests are disabled because a bug has been uncovered
that it was actually still using onnx-mlir instead of CompilerLibTest
to compile the models. Fix the bug to use CompilerLibTest and
it fails to compile the models.

Use CTEST_PARALLEL_LEVEL for numerical tests to be compatible
with Windows CI

Signed-off-by: Gong Su <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Use ninja as a build system (llvm#946)

Signed-off-by: mshr-h <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Added documentation on using DEBUG according to LLVM (llvm#970)

* added documentation on using DEBUG according to LLVM

Signed-off-by: Alexandre Eichenberger <[email protected]>

* removed errand printf for debugging

Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* CategoryMapper: shape inference support. (llvm#971)

Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Updating docs to move into the right place (llvm#972)

* Updating docs to move into the right place

Signed-off-by: Alexandre Eichenberger <[email protected]>

* add link

Signed-off-by: Alexandre Eichenberger <[email protected]>

* add links

Signed-off-by: Alexandre Eichenberger <[email protected]>

* add links

Signed-off-by: Alexandre Eichenberger <[email protected]>

* respond to comments on MLIR.cmake

Signed-off-by: Alexandre Eichenberger <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Fix EnableMemoryPool to account for 'memref.cast' operation. (llvm#966)

Signed-off-by: Ettore Tiotto <[email protected]>
Signed-off-by: Yasushi Negishi <[email protected]>

* Fix typo.

Signed-off-by: Yasushi Negishi <[email protected]>

* Revert "Fix typo."

This reverts commit f2934faee463557ebc2adb6aca5b9521f5064f12.

Signed-off-by: Yasushi Negishi <[email protected]>

* Fix typo

Signed-off-by: Yasushi Negishi <[email protected]>

Co-authored-by: Alexandre Eichenberger <[email protected]>
Co-authored-by: Tung D. Le <[email protected]>
Co-authored-by: Stella Stamenova <[email protected]>
Co-authored-by: DavidChan <[email protected]>
Co-authored-by: david.cheng <[email protected]>
Co-authored-by: Michael Holman <[email protected]>
Co-authored-by: gongsu832 <[email protected]>
Co-authored-by: Masahiro Hiramori <[email protected]>
Co-authored-by: Ettore Tiotto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants